JayjeetAtGithub commented on a change in pull request #10431:
URL: https://github.com/apache/arrow/pull/10431#discussion_r683607845
##########
File path: cpp/src/arrow/dataset/scanner_internal.h
##########
@@ -185,6 +185,12 @@ inline Result<ScanTaskIterator> GetScanTaskIterator(
auto fn = [options](std::shared_ptr<Fragment> fragment) ->
Result<ScanTaskIterator> {
ARROW_ASSIGN_OR_RAISE(auto scan_task_it, fragment->Scan(options));
+ if (fragment->type_name() == "skyhook") {
Review comment:
Yes, filtering (although is quite fast) incurs some overhead. Maybe we
can have a flag in `ScanOptions` to switch on/off client-side filtering ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
