roee88 commented on a change in pull request #674:
URL: https://github.com/apache/arrow-rs/pull/674#discussion_r684725663
##########
File path: .github/workflows/rust.yml
##########
@@ -327,12 +327,14 @@ jobs:
rustup override set ${{ matrix.rust }}
rustup component add rustfmt
rustup target add wasm32-unknown-unknown
+ rustup target add wasm32-wasi
- name: Build arrow crate
run: |
export CARGO_HOME="/github/home/.cargo"
export CARGO_TARGET_DIR="/github/home/target"
cd arrow
- cargo build --features=js --target wasm32-unknown-unknown
+ cargo build --no-default-features --features=csv,ipc,simd --target
wasm32-unknown-unknown
+ cargo build --no-default-features --features=csv,ipc,simd --target
wasm32-wasi
Review comment:
Specifically for `wasm32-wasi` there is no real need to exclude test
dependencies so `cargo build --features=simd --target wasm32-wasi` or `cargo
build --target wasm32-wasi` also work. However, I don't see a real reason to
include it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
