nevi-me commented on a change in pull request #674:
URL: https://github.com/apache/arrow-rs/pull/674#discussion_r684732620
##########
File path: arrow/README.md
##########
@@ -59,11 +59,13 @@ println!("{:?}", array.value(1));
## Building for WASM
-In order to compile Arrow for Web Assembly (the `wasm32-unknown-unknown` WASM
target), you will likely need to turn off this crate's default features and use
the `js` feature.
+Arrow can compile to WebAssembly using the `wasm32-unknown-unknown` and
`wasm32-wasi` targets.
+
+In order to compile Arrow for `wasm32-unknown-unknown` you will need to
exclude test dependencies (the `test_utils` feature). For example, use this
snippet in your `Cargo.toml`:
```toml
[dependencies]
-arrow = { version = "5.0", default-features = false, features = ["js"] }
+arrow = { version = "5.0", default-features = false, features = ["csv", "ipc",
"simd"] }
Review comment:
This doesn't clearly articulate what's happening, compared to what's
being changed. How about:
"In order to compile Arrow for `wasm32-unknown-unknown` you will need to
disable default features, then include the desired features, but exclude test
dependencies (the `test_utils` feature). For example, use this snippet in your
`Cargo.toml`:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
