houqp commented on a change in pull request #840:
URL: https://github.com/apache/arrow-datafusion/pull/840#discussion_r684913244
##########
File path: datafusion/src/physical_plan/functions.rs
##########
@@ -277,8 +277,8 @@ impl FromStr for BuiltinScalarFunction {
"concat" => BuiltinScalarFunction::Concat,
"concat_ws" => BuiltinScalarFunction::ConcatWithSeparator,
"chr" => BuiltinScalarFunction::Chr,
- "date_part" => BuiltinScalarFunction::DatePart,
- "date_trunc" => BuiltinScalarFunction::DateTrunc,
+ "date_part" | "datepart" => BuiltinScalarFunction::DatePart,
+ "date_trunc" | "datetrunc" => BuiltinScalarFunction::DateTrunc,
Review comment:
Ballista physical plan ser/de uses function.to_string() to serialize the
name, which uses the enum name and resulted in function name without `_`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
