houqp commented on a change in pull request #840:
URL: https://github.com/apache/arrow-datafusion/pull/840#discussion_r684969916
##########
File path: ballista/rust/core/proto/ballista.proto
##########
@@ -144,18 +144,19 @@ enum ScalarFunction {
TOTIMESTAMP = 24;
ARRAY = 25;
NULLIF = 26;
- DATETRUNC = 27;
- MD5 = 28;
- SHA224 = 29;
- SHA256 = 30;
- SHA384 = 31;
- SHA512 = 32;
- LN = 33;
+ DATEPART = 27;
Review comment:
Yep, there is another breaking change in ScalarFunctionNode where i
renamed `expr` field to `args`. Both of these changes are done purely for
improving readability of the code base.
I think we should start to be careful about breaking change when we start to
receive interests in using ballista for production PoC. But if any one thinks
we shouldn't introduce breaking change for readability even at current stage, I
am more than happy to revert these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
