alamb opened a new pull request #844: URL: https://github.com/apache/arrow-datafusion/pull/844
# Which issue does this PR close? Re #790 / part of https://github.com/apache/arrow-datafusion/pull/808 which can be reviewed independently # Rationale for this change 1. For the group by hash algorithm in #808, being able to compare values in `[ArrayRef]` to `[ScalarValue]` is in the performance critical section and thus should be optimized. Creating `ScalarValue`s from the `ArrayRef`s is too slow and results in copying. # What changes are included in this PR? 1. Add a specialized `eq_array` function to `ScalarValue` 2. Test for same 3. A bug fix for null handling in `ScalarValue::try_from_array` for dictionary arrays # Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
