alamb commented on a change in pull request #844:
URL: https://github.com/apache/arrow-datafusion/pull/844#discussion_r685313180
##########
File path: datafusion/src/scalar.rs
##########
@@ -277,6 +277,31 @@ impl std::hash::Hash for ScalarValue {
}
}
+// return the index into the dictionary values for array@index as well
+// as a reference to the dictionary values array. Returns None for the
+// index if the array is NULL at index
Review comment:
https://github.com/apache/arrow-rs/issues/672 proposes adding this
upstream in arrow
I think this properly handles `null` values now in the DictionaryArray,
whereas y initial version did not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
