alamb opened a new pull request #901: URL: https://github.com/apache/arrow-datafusion/pull/901
# Which issue does this PR close? Closes https://github.com/apache/arrow-datafusion/issues/679 Note: If people basically like this API I will go ahead and add unit tests for metrics.rs (e.g. for aggregate_by_partition) # Rationale for this change See the description on https://github.com/apache/arrow-datafusion/issues/679#issue-937015511 for the full rationale, but the TLDR version is: 1. Better align `SQLMetric` data model to ease integration in other metric systems (e.g. prometheus, influxdb, etc) 2. Ability to get per-partition metrics 3. Ability to get current metric values *during* execution # What changes are included in this PR? 1. Update the `SQLMetric` API to be in its own module, have labels, know about partitions, and allow for real time inspection 2. Update uses of `SQLMetric` in DataFusion and Ballista to the new API 2. Functionality to aggregate (sum) metrics via predicate and via partition # Are there any user-facing changes? No The SQLMetric API is basically now totally different so any code that creates / uses `SQLMetrics` would have to be updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
