alamb commented on pull request #901: URL: https://github.com/apache/arrow-datafusion/pull/901#issuecomment-901359513
@andygrove / @returnString as you implemented the `SQLMetric`s initially and have worked with them, do you have any context or opinion on the use of `snake_case` vs `camelCase` names for the metrics? For example `numRows` vs `num_rows`? From this PR's original description: > The current SQL counters use "camel case" for the counter names (e.g. `numRows`) rather than the Rust standard "snake case" (e.g. `num_rows`). I kept the same naming convention in this PR, but I wonder if we want to make them more Rust standard snake case given we are messing with them all anyways. @tustvold notes that > Edit: r.e. snake case vs camel case, FWIW most metrics systems I've interacted with don't support upper-case letters, nor hyphens, so snake case is pretty typical Given that snake case is the standard in Rust as well, I would probably be inclined to update the metric names to use snake case as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
