emkornfield commented on a change in pull request #10177: URL: https://github.com/apache/arrow/pull/10177#discussion_r691021404
########## File path: java/vector/src/main/java/org/apache/arrow/vector/PeriodDuration.java ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.arrow.vector; + +import java.time.Duration; +import java.time.Period; + +/** + * Combination of Period and Duration for representing this interval type + * as a POJO. + */ +public class PeriodDuration { + private final Period period; + private final Duration duration; + + public PeriodDuration(Period period, Duration duration) { + this.period = period; + this.duration = duration; + } + + public Period getPeriod() { + return period; + } + + public Duration getDuration() { + return duration; + } + + @Override + public String toString() { + return period.toString() + " " + duration.toString(); + } + + @Override + public boolean equals(Object o) { + if (!(o instanceof PeriodDuration)) { + return false; + } + PeriodDuration other = (PeriodDuration) o; + return this.period.equals(other.period) && this.duration.equals(other.duration); Review comment: no .added check not null. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
