emkornfield commented on a change in pull request #10177: URL: https://github.com/apache/arrow/pull/10177#discussion_r694477958
########## File path: java/vector/src/test/java/org/apache/arrow/vector/TestPeriodDuration.java ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.arrow.vector; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNotEquals; + +import java.time.Duration; +import java.time.Period; + +import org.junit.Test; + +public class TestPeriodDuration { + + @Test + public void testBasics() { + PeriodDuration pd1 = new PeriodDuration(Period.of(1, 2, 3), Duration.ofNanos(123)); + PeriodDuration pdEq1 = new PeriodDuration(Period.of(1, 2, 3), Duration.ofNanos(123)); + PeriodDuration pd2 = new PeriodDuration(Period.of(1, 2, 3), Duration.ofNanos(12)); + PeriodDuration pd3 = new PeriodDuration(Period.of(1, 2, 0), Duration.ofNanos(123)); Review comment: done. ########## File path: cpp/src/arrow/testing/random.cc ########## @@ -998,6 +1004,36 @@ std::shared_ptr<arrow::RecordBatch> GenerateBatch(const FieldVector& fields, int64_t length, SeedType seed) { return RandomArrayGenerator(seed).BatchOf(fields, length); } - } // namespace random + +void rand_day_millis(int64_t N, std::vector<DayTimeIntervalType::DayMilliseconds>* out) { + const int random_seed = 0; + std::default_random_engine gen(random_seed); Review comment: done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
