alamb commented on a change in pull request #923:
URL: https://github.com/apache/arrow-datafusion/pull/923#discussion_r693867753
##########
File path: pre-commit.sh
##########
@@ -20,7 +20,7 @@
# This file is git pre-commit hook.
#
# Soft link it as git hook under top dir of apache arrow git repository:
-# $ ln -s ../../rust/pre-commit.sh .git/hooks/pre-commit
Review comment:
I would recommend a separate PR in future cases -- mostly so we can tag
the original author of the pre-commit and have a discussion about what to do
there without holding up this PR
This change looks uncontentious, but since I don't use the pre-commit.sh
hook I am not sure how to test it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]