francis-du commented on a change in pull request #923:
URL: https://github.com/apache/arrow-datafusion/pull/923#discussion_r693898063
##########
File path: datafusion/src/dataframe.rs
##########
@@ -223,6 +223,21 @@ pub trait DataFrame: Send + Sync {
/// ```
async fn collect(&self) -> Result<Vec<RecordBatch>>;
+ /// Print results.
+ ///
+ /// ```
+ /// # use datafusion::prelude::*;
+ /// # use datafusion::error::Result;
+ /// # #[tokio::main]
+ /// # async fn main() -> Result<()> {
+ /// let mut ctx = ExecutionContext::new();
+ /// let df = ctx.read_csv("tests/example.csv", CsvReadOptions::new())?;
+ /// df.show().await?;
+ /// # Ok(())
+ /// # }
+ /// ```
+ async fn show(&self) -> Result<()>;
Review comment:
I think it can be inferred from the logical plan whether there is a
limit number. If there is no limit, set it to the default value of 20. If there
is, then the default limit value is not set.
This is an implementation:
```rust
async fn show(&self) -> Result<()> {
let mut num = 20;
match self.to_logical_plan() {
LogicalPlan::Limit { n, input } => {
if n > num {
num = n;
}
}
_ => {}
}
let results = self.limit(num)?.collect().await?;
Ok(pretty::print_batches(&results)?)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
