jonkeane commented on a change in pull request #11000:
URL: https://github.com/apache/arrow/pull/11000#discussion_r695943183
##########
File path: r/tools/nixlibs.R
##########
@@ -215,10 +215,8 @@ download_source <- function() {
# Given VERSION as x.y.z.p
p <- package_version(VERSION)[1, 4]
- if (is.na(p) || p < 1000) {
- # This is either just x.y.z or it has a small (R-only) patch version
- # Download from the official Apache release, dropping the p
- VERSION <- as.character(package_version(VERSION)[1, -4])
+ if (is.na(p)) {
Review comment:
This isn't quite right (see my comment below about confusion between
`apache_download()` and `nightly_download()`). Removing the `p < 1000` is fine
here, but I wonder if we should change [line
225](https://github.com/apache/arrow/pull/11000/files#diff-935746c34b16289a07b0d9bf7642dbd268b18059b6187f7cdec7c464be47a3deR225)
to be:
```
} else if (p <= 9000 | p > 9999) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
