jonkeane commented on a change in pull request #11000:
URL: https://github.com/apache/arrow/pull/11000#discussion_r695941162
##########
File path: r/tools/nixlibs.R
##########
@@ -215,10 +215,8 @@ download_source <- function() {
# Given VERSION as x.y.z.p
p <- package_version(VERSION)[1, 4]
- if (is.na(p) || p < 1000) {
- # This is either just x.y.z or it has a small (R-only) patch version
- # Download from the official Apache release, dropping the p
- VERSION <- as.character(package_version(VERSION)[1, -4])
+ if (is.na(p)) {
+ # This is just x.y.z so download the official Apache release
Review comment:
Oh, actually I'm wrong here, our (possible) minor patch release would be
downloaded through `nightly_download()` not `apache_download()` (and be moved
to the nightly download chunk in lines 225-233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
