jhorstmann commented on a change in pull request #714:
URL: https://github.com/apache/arrow-rs/pull/714#discussion_r696837777
##########
File path: arrow/src/alloc/types.rs
##########
@@ -36,7 +36,7 @@ pub unsafe trait NativeType:
}
macro_rules! create_native {
- ($native_ty:ty,$($impl_pattern:pat)|+) => {
+ ($native_ty:ty,$($impl_pattern:pat_param)|+) => {
Review comment:
@alamb Either I have something misconfigured locally or this change
breaks compilation with the version 1.52.1 configured in rust-toolchain:
```
error: invalid fragment specifier `pat_param`
--> arrow/src/alloc/types.rs:39:22
|
39 | ($native_ty:ty,$($impl_pattern:pat_param)|+) => {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: valid fragment specifiers are `ident`, `block`, `stmt`, `expr`,
`pat`, `ty`, `lifetime`, `literal`, `path`, `meta`, `tt`, `item` and `vis`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
