Jimexist commented on a change in pull request #714:
URL: https://github.com/apache/arrow-rs/pull/714#discussion_r697835220



##########
File path: arrow/src/alloc/types.rs
##########
@@ -36,7 +36,7 @@ pub unsafe trait NativeType:
 }
 
 macro_rules! create_native {
-    ($native_ty:ty,$($impl_pattern:pat)|+) => {
+    ($native_ty:ty,$($impl_pattern:pat_param)|+) => {

Review comment:
       it's either that or you note in the release notes that the minimal 
support rust version is 1.53.
   
   rust edition 2021 is likely land in rust 1.56. and given my understanding 
that arrow does not promise a specific back-compatible yet I feel like that 
users are supposed to upgrade to latest stable. but my understanding could be 
wrong.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to