rok commented on a change in pull request #10998:
URL: https://github.com/apache/arrow/pull/10998#discussion_r697041218



##########
File path: python/pyarrow/tests/test_compute.py
##########
@@ -1492,18 +1492,25 @@ def _fix_timestamp(s):
 
         # Test setting locale
         tsa = pa.array(ts, type=pa.timestamp("s", timezone))
-        options = pc.StrftimeOptions("%Y-%m-%dT%H:%M:%SZ", "C")

Review comment:
       Actually all formatting flags [are 
tested](https://github.com/apache/arrow/blob/554a1871f02adc9f094562dccec321c95838eabb/python/pyarrow/tests/test_compute.py#L1483)
 (but not visible in this diff). I've added a default format plus timezone test 
to make it more explicit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to