rok commented on a change in pull request #10998:
URL: https://github.com/apache/arrow/pull/10998#discussion_r697041446
##########
File path: cpp/src/arrow/compute/kernels/scalar_temporal_test.cc
##########
@@ -414,12 +414,18 @@ TEST_F(ScalarTemporalTest, Strftime) {
}
TEST_F(ScalarTemporalTest, StrftimeNoTimezone) {
+ auto options_default = StrftimeOptions();
const char* seconds = R"(["1970-01-01T00:00:59", null])";
auto arr = ArrayFromJSON(timestamp(TimeUnit::SECOND), seconds);
+
+ CheckScalarUnary("strftime", timestamp(TimeUnit::SECOND), seconds, utf8(),
seconds,
+ &options_default);
EXPECT_RAISES_WITH_MESSAGE_THAT(
- Invalid,
- testing::HasSubstr("Timestamps without a time zone cannot be reliably
formatted"),
- Strftime(arr, StrftimeOptions()));
+ Invalid, testing::HasSubstr("Invalid: Timezone not present, cannot
print"),
Review comment:
Yeah, good point. I went with your first proposal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
