aocsa commented on a change in pull request #11019: URL: https://github.com/apache/arrow/pull/11019#discussion_r700731263
########## File path: cpp/src/arrow/compute/kernels/vector_sort.cc ########## @@ -1778,6 +1784,711 @@ class SortIndicesMetaFunction : public MetaFunction { } }; +// ---------------------------------------------------------------------- +// TopK/BottomK implementations + +using SelectKOptionsState = internal::OptionsWrapper<SelectKOptions>; +const auto kDefaultTopKOptions = SelectKOptions::TopKDefault(); +const auto kDefaultBottomKOptions = SelectKOptions::BottomKDefault(); + +const FunctionDoc top_k_doc( + "Return the indices that would partition an array array, record batch or table\n" + "around a pivot", + ("@TODO"), {"input", "k"}, "PartitionNthOptions"); Review comment: I though that kernel arity contains the number of required arguments for the function. This function requires at least it is required the input and k. So arity should be binary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org