wmalpica commented on a change in pull request #11064:
URL: https://github.com/apache/arrow/pull/11064#discussion_r701412715
##########
File path: cpp/src/arrow/util/value_parsing.h
##########
@@ -273,6 +273,96 @@ inline bool ParseUnsigned(const char* s, size_t length,
uint64_t* out) {
#undef PARSE_UNSIGNED_ITERATION
#undef PARSE_UNSIGNED_ITERATION_LAST
+#define PARSE_HEX_ITERATION(C_TYPE) \
+ if (length > 0) { \
Review comment:
I agree with this recommendation. I was following the pattern of how
`ParseUnsigned` and `PARSE_UNSIGNED_ITERATION` is done in the same file. Since
I am new to the codebase I decided to follow the patterns I was seeing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
