wmalpica commented on a change in pull request #11064:
URL: https://github.com/apache/arrow/pull/11064#discussion_r704684918
##########
File path: cpp/src/arrow/util/value_parsing.h
##########
@@ -273,6 +273,36 @@ inline bool ParseUnsigned(const char* s, size_t length,
uint64_t* out) {
#undef PARSE_UNSIGNED_ITERATION
#undef PARSE_UNSIGNED_ITERATION_LAST
+
+
+template <typename T>
+bool ParseHex(const char* s, size_t length, T* out) {
+ T result = 0;
+ int num_iterations = (int)(sizeof(T)*2);
Review comment:
good point. Implemented this
##########
File path: cpp/src/arrow/util/value_parsing.h
##########
@@ -329,13 +373,31 @@ struct StringToSignedIntConverterMixin {
if (ARROW_PREDICT_FALSE(length == 0)) {
return false;
}
+
+ // If its starts with 0x then its hex
+ if (*s == '0' && ((*(s + 1) == 'x') || (*(s + 1) == 'X'))){
+ length -= 2;
+ s += 2;
+
+ // lets make sure that the length of the string is not too big
+ if (!ARROW_PREDICT_TRUE(sizeof(unsigned_value)*2 >= length && length >
0)) {
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
