karldw edited a comment on pull request #11001: URL: https://github.com/apache/arrow/pull/11001#issuecomment-912747988
Thanks! I learned a bunch doing this. I had a couple minor questions, following up on comments from @nealrichardson: 1. Should I swap the argument order for `create_package_with_all_dependencies`? 2. Should `create_package_with_all_dependencies` check `ARROW_THIRDPARTY_DEPENDENCY_DIR`? 3. Before this is finalized, do you want to change any of the new names I've made up? (edit) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org