jonkeane commented on a change in pull request #11001:
URL: https://github.com/apache/arrow/pull/11001#discussion_r702305430
##########
File path: r/R/install-arrow.R
##########
@@ -137,3 +136,93 @@ reload_arrow <- function() {
message("Please restart R to use the 'arrow' package.")
}
}
+
+
+#' Create a source bundle that includes all thirdparty dependencies
+#'
+#' @param dest_file File path for the new tar.gz package. Defaults to
+#' `arrow_V.V.V_with_deps.tar.gz` in the current directory (`V.V.V` is the
version)
+#' @param source_file File path for the input tar.gz package. Defaults to
+#' downloading the package from CRAN (or whatever you have set as the first in
+#' `getOption("repos")`)
+#' @return The full path to `dest_file`, invisibly
+#'
+#' This function is used for setting up an offline build. If it's possible to
+#' download at build time, don't use this function. Instead, let `cmake`
+#' download the required dependencies for you.
+#' These downloaded dependencies are only used in the build if
+#' `ARROW_DEPENDENCY_SOURCE` is unset, `BUNDLED`, or `AUTO`.
+#' https://arrow.apache.org/docs/developers/cpp/building.html#offline-builds
+#'
Review comment:
```suggestion
#'
#' Note: If you're using RStudio Package Manager to download binary packages
on
#' linux you shouldn't need to use this function. You can download the
appropriate
#' binary from RStudio Package Manager, and transfer that to the offline
computer.
#' If you still do want to make a source bundle with this function, make
sure to
#' set the first repo in `options("repos")` to be a mirror that contains
source
#' packages (that is: something other than the RStudio Package Manager
binary
#' mirror URLs).
#'
```
How about adding this to the docs. We could do something like sniff to see
if `libarrow.so` is in the package downloaded, but that is fragile + this is a
pretty unique workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
