houqp commented on pull request #974: URL: https://github.com/apache/arrow-datafusion/pull/974#issuecomment-913780939
@xudong963 Notice that `TableDescriptorBuilder::new` takes ownership of the passed in str: https://github.com/apache/arrow-datafusion/blob/7932cb9373192ce2754b39c1f82f22c8a56b7266/datafusion/src/datasource/mod.rs#L169 I think it would be more efficient to propagate the `impl Into<String>` generic signature all the way into `TableDescriptorBuilder::build_table_desc`. cc @yjshen to see if you have any opinion on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
