xudong963 edited a comment on pull request #974: URL: https://github.com/apache/arrow-datafusion/pull/974#issuecomment-913955597
@houqp now caller passes `path: &str` to `ParquetTable::try_new()`, so `path.into()` make copy to generate String. if we propagate the impl Into<String> generic signature all the way into `TableDescriptorBuilder::build_table_desc`, we can avoid copy in `TableDescriptorBuilder::new`. But if use `&str` in `ParquetTable::try_new()`, we can avoid copy in `ParquetTable::try_new()` and copy in `TableDescriptorBuilder::build_table_desc`. Both will make one copy, but the second makes the code concise. I am newly to rust, happy to point my mistake~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
