yjshen commented on a change in pull request #972:
URL: https://github.com/apache/arrow-datafusion/pull/972#discussion_r703136372
##########
File path: ballista/rust/core/src/serde/logical_plan/from_proto.rs
##########
@@ -157,17 +157,17 @@ impl TryInto<LogicalPlan> for &protobuf::LogicalPlanNode {
Some(r?)
}
};
-
Review comment:
Perhaps we should move `max_partitions` out of the logical plan nodes
and postpone it to physical plan generation. In `TableProvider.scan` for
example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
