houqp commented on a change in pull request #972:
URL: https://github.com/apache/arrow-datafusion/pull/972#discussion_r703140772



##########
File path: ballista/rust/core/src/serde/logical_plan/from_proto.rs
##########
@@ -157,17 +157,17 @@ impl TryInto<LogicalPlan> for &protobuf::LogicalPlanNode {
                         Some(r?)
                     }
                 };
-

Review comment:
       How do we get the value for `max_partitions` in the scan method? Right 
now this config is provided by the user when creating the TableProvider struct, 
so I think something needs to be changed there.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to