edponce commented on a change in pull request #10349:
URL: https://github.com/apache/arrow/pull/10349#discussion_r703465473
##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -85,26 +78,32 @@ enum class RoundMode : int8_t {
HALF_TO_ODD,
};
+static constexpr double kDefaultAbsoluteTolerance = 1E-5;
+
class ARROW_EXPORT RoundOptions : public FunctionOptions {
public:
explicit RoundOptions(int64_t ndigits = 0,
- RoundMode round_mode = RoundMode::HALF_TO_EVEN);
+ RoundMode round_mode = RoundMode::HALF_TO_EVEN,
+ double atol = kDefaultAbsoluteTolerance);
constexpr static char const kTypeName[] = "RoundOptions";
static RoundOptions Defaults() { return RoundOptions(); }
/// Rounding precision (number of digits to round to).
int64_t ndigits;
RoundMode round_mode;
+ double atol;
Review comment:
Thanks for noticing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
