edponce commented on a change in pull request #10349:
URL: https://github.com/apache/arrow/pull/10349#discussion_r703584951



##########
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##########
@@ -896,7 +915,8 @@ struct RoundImpl<T, RoundMode::UP> {
 template <typename T>
 struct RoundImpl<T, RoundMode::TOWARDS_ZERO> {
   static constexpr enable_if_floating_point<T> Round(const T val) {
-    return std::trunc(val);
+    // return std::trunc(val);

Review comment:
       This was a place holder while I thought more about how to solve the 
problem.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to