edponce commented on a change in pull request #10349:
URL: https://github.com/apache/arrow/pull/10349#discussion_r703909808



##########
File path: cpp/src/arrow/python/python_test.cc
##########
@@ -194,7 +194,7 @@ TEST(PyBuffer, InvalidInputObject) {
 // ("unresolved external symbol arrow_ARRAY_API referenced").
 #ifndef _WIN32
 TEST(PyBuffer, NumpyArray) {
-  const npy_intp dims[1] = {10};
+  npy_intp dims[1] = {10};

Review comment:
       I do not recall if it was in CI or a compiler on my side, but build was 
triggering error w.r.t. to `const npy_intp *` in  `PyArray_SimpleNew`. I had 
not seen this issue before and the `const` attribute is present in the latest 
NumPy API but it was not there at some point. I revert this change, but note 
that this TEST uses `const npy_intp` and the following below does not.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to