alamb commented on pull request #922: URL: https://github.com/apache/arrow-datafusion/pull/922#issuecomment-916982517
> Hi @alamb - I've used datafusion_aggregate_bench to run up a comparison with master and the ratios are coming up at 0.99 so there's nothing significant in the way of a performance improvement yet. One reason you may not have seen any difference is that the aggregate benchmark has nulls in the grouping keys. Perhaps adjusting the following numbers and ensuring your code path is hit would be a good next step https://github.com/alamb/datafusion_aggregate_bench/blob/main/src/main.rs#L23-L24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
