alamb commented on pull request #922:
URL: https://github.com/apache/arrow-datafusion/pull/922#issuecomment-917612720


   > This is confusing to me ... perhaps the is_valid() call is not as 
expensive as we thought?
   
   Thanks for the update @novemberkilo 👍 
   
   This is definitely possible. I don't think we have measured the specific 
contribution that checking for nulls added to the overall runtime. If it turns 
out we can't see a difference in performance, perhaps the additional code 
complexity isn't worth it. 
   
   Unfortunately this does happen sometime while doing performance 
optimizations :( I am sorry if I mislead you here. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to