jorgecarleitao commented on a change in pull request #68:
URL: https://github.com/apache/arrow-datafusion/pull/68#discussion_r706565686
##########
File path: datafusion/src/scalar.rs
##########
@@ -64,7 +70,10 @@ pub enum ScalarValue {
/// large binary
LargeBinary(Option<Vec<u8>>),
/// list of nested ScalarValue
- List(Option<Vec<ScalarValue>>, DataType),
+ // 1st argument are the inner values (e.g. Int64Array)
+ // 2st argument is the Lists' datatype (i.e. it includes `Field`)
+ // to downcast inner values, use ListArray::<i32>::get_child()
+ List(Option<Arc<dyn Array>>, DataType),
Review comment:
`List[i] -> ScalarList` is a `O(1)` operation in arrow via
`list.value(i).into()`, we make it a `O(N)` by casting each element to `scalar`.
Not married, though, was just trying to simplify the `scalar<->array`
interaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
