houqp commented on a change in pull request #68:
URL: https://github.com/apache/arrow-datafusion/pull/68#discussion_r707044869
##########
File path: datafusion/src/scalar.rs
##########
@@ -64,7 +70,10 @@ pub enum ScalarValue {
/// large binary
LargeBinary(Option<Vec<u8>>),
/// list of nested ScalarValue
- List(Option<Vec<ScalarValue>>, DataType),
+ // 1st argument are the inner values (e.g. Int64Array)
+ // 2st argument is the Lists' datatype (i.e. it includes `Field`)
+ // to downcast inner values, use ListArray::<i32>::get_child()
+ List(Option<Arc<dyn Array>>, DataType),
Review comment:
For the protobuf ser/der, one thing we could do is to send the `dyan
Array` over the wire as arrow ipc stream encoded as bytes in protobuf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
