sum12 opened a new pull request #771:
URL: https://github.com/apache/arrow-rs/pull/771
The patch rewrites the behaviour using macros to indicate the
repetitive nutate of operations
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Does not really close #500 but fixes it partially as even after this PR is
merged only certain tz formats will be recognized.
Closes #.
# Rationale for this change
The change uses timezone from array while calculating second/minute/hour for
the array elements. This is currently being ignored.
<!---
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
The changes in this PR only partially close the bug. When the timezone is
not specified the format expected by the chrono library then an error is
returned.
<!---
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
Anything of the form [+-]XX:XX will be recognized but nothing of the form
eg America/Newyork will start returning error
<!---
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking
change` label.
-->
Not sure if this is a breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
