sum12 commented on a change in pull request #771:
URL: https://github.com/apache/arrow-rs/pull/771#discussion_r716830130
##########
File path: arrow/src/array/array_primitive.rs
##########
@@ -232,6 +232,19 @@ where
as_datetime::<T>(i64::from(self.value(i)))
}
+ /// Returns value as a chrono `NaiveDateTime`, handling time resolution
with the provided tz
Review comment:
Doing it so that further change is not needed sounds like a good
approach.
How about using `Tz: Offset` instead ?
I am not sure how `TimeZone` can be used here. How would one convert the the
`NaiveDateTime` into a another `NaiveDateTime` with the offset added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
