lidavidm commented on a change in pull request #11111:
URL: https://github.com/apache/arrow/pull/11111#discussion_r707578515
##########
File path: cpp/src/arrow/compute/kernels/codegen_internal.h
##########
@@ -407,12 +407,19 @@ ArrayKernelExec MakeFlippedBinaryExec(ArrayKernelExec
exec);
// Helpers for iterating over common DataType instances for adding kernels to
// functions
+ARROW_EXPORT
const std::vector<std::shared_ptr<DataType>>& BaseBinaryTypes();
Review comment:
Those are for compile-time parameterization while the test in
hash_aggregate_test.cc uses these for runtime parameterization. But it's not
such a big deal, so I'll convert it to use TYPED_TEST.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
