lidavidm commented on a change in pull request #11111:
URL: https://github.com/apache/arrow/pull/11111#discussion_r707653421
##########
File path: cpp/src/arrow/compute/kernels/aggregate_basic_internal.h
##########
@@ -220,16 +220,24 @@ struct MinMaxState<ArrowType, SimdLevel,
enable_if_boolean<ArrowType>> {
this->max = this->max || value;
}
+ Status GetValues(const std::shared_ptr<DataType>&,
+ std::vector<std::shared_ptr<Scalar>>* values) {
+ values->emplace_back(std::make_shared<BooleanScalar>(min));
+ values->emplace_back(std::make_shared<BooleanScalar>(max));
+ return Status::OK();
+ }
+
T min = true;
T max = false;
bool has_nulls = false;
bool has_values = false;
};
template <typename ArrowType, SimdLevel::type SimdLevel>
-struct MinMaxState<ArrowType, SimdLevel, enable_if_integer<ArrowType>> {
+struct MinMaxState<ArrowType, SimdLevel,
enable_if_physical_integer<ArrowType>> {
Review comment:
I changed this and the one below to use PhysicalType. I also replaced
GetValues with MakeScalar (since now the static type doesn't match the runtime
type).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
