cyb70289 commented on a change in pull request #11135:
URL: https://github.com/apache/arrow/pull/11135#discussion_r707846460
##########
File path: cpp/src/arrow/io/hdfs_internal.cc
##########
@@ -215,7 +215,7 @@ Result<std::vector<PlatformFilename>>
get_potential_libjvm_paths() {
}));
ARROW_ASSIGN_OR_RAISE(search_suffixes,
MakeFilenameVector({"", "/jre/lib/amd64/server",
- "/lib/amd64/server",
"/lib/server"}));
+ "/lib/amd64/server",
"/lib/server","/jre/lib/aarch64/server"}));
Review comment:
On Debian Arm64, libjvm.so is under
`/usr/lib/jvm/java-8-openjdk-arm64/jre/lib/aarch64/server/libjvm.so`
https://packages.debian.org/hu/stretch/arm64/openjdk-8-jre-headless/filelist
Besides this *suffixes* change, we should also update the *prefixes*.
https://github.com/apache/arrow/blob/master/cpp/src/arrow/io/hdfs_internal.cc#L201-L206
##########
File path: cpp/src/arrow/io/hdfs_internal.cc
##########
@@ -215,7 +215,7 @@ Result<std::vector<PlatformFilename>>
get_potential_libjvm_paths() {
}));
ARROW_ASSIGN_OR_RAISE(search_suffixes,
MakeFilenameVector({"", "/jre/lib/amd64/server",
- "/lib/amd64/server",
"/lib/server"}));
+ "/lib/amd64/server",
"/lib/server","/jre/lib/aarch64/server"}));
Review comment:
Mixing `amd64` and `aarch64` is one list looks not good.
We can define the `arch` string per compiler architecture and do
`"/jre/lib/" + arch + "/server"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
