cyb70289 commented on a change in pull request #11135:
URL: https://github.com/apache/arrow/pull/11135#discussion_r708121735



##########
File path: cpp/src/arrow/io/hdfs_internal.cc
##########
@@ -215,7 +215,7 @@ Result<std::vector<PlatformFilename>> 
get_potential_libjvm_paths() {
       }));
   ARROW_ASSIGN_OR_RAISE(search_suffixes,
                         MakeFilenameVector({"", "/jre/lib/amd64/server",
-                                            "/lib/amd64/server", 
"/lib/server"}));
+                                            "/lib/amd64/server", 
"/lib/server","/jre/lib/aarch64/server"}));

Review comment:
       Something like this:
   
   ```
   #if defined(__aarch64__)
   const std::string prefix_arch{"arm64"};
   const std::string suffix_arch{"aarch64"};
   #else
   const std::string prefix_arch{"amd64"};
   const std::string suffix_arch{"amd64"};
   #endif
   ARROW_ASSIGN_OR_RAISE(
         search_prefixes,
         MakeFilenameVector({
             ......
             "/usr/local/lib/jvm/java-8-openjdk-" + prefix_arch,  // alt ubuntu 
/ debian distros
             "/usr/lib/jvm/java-8-openjdk-" + prefix_arch,        // alt ubuntu 
/ debian distros
             ......
         }));
     ARROW_ASSIGN_OR_RAISE(search_suffixes,
                           MakeFilenameVector({"", "/lib/server",
                                               "/jre/lib/" + suffix_arch + 
"/server", "/lib/" + suffix_arch + "/server"}));
     file_name = "libjvm.so";
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to