cyb70289 commented on a change in pull request #11161:
URL: https://github.com/apache/arrow/pull/11161#discussion_r709689761
##########
File path: cpp/src/arrow/util/value_parsing.h
##########
@@ -273,6 +273,30 @@ inline bool ParseUnsigned(const char* s, size_t length,
uint64_t* out) {
#undef PARSE_UNSIGNED_ITERATION
#undef PARSE_UNSIGNED_ITERATION_LAST
+template <typename T>
+bool ParseHex(const char* s, size_t length, T* out) {
+ // lets make sure that the length of the string is not too big
+ if (!ARROW_PREDICT_TRUE(sizeof(T) * 2 >= length && length > 0)) {
+ return false;
+ }
+ T result = 0;
+ for (size_t i = 0; i < length; i++) {
+ result = static_cast<T>(result << 4);
+ if (s[i] >= '0' && s[i] <= '9') {
+ result = static_cast<T>(result | (s[i] - '0'));
+ } else if (s[i] >= 'A' && s[i] <= 'F') {
+ result = static_cast<T>(result | (s[i] - 'A' + 10));
+ } else if (s[i] >= 'a' && s[i] <= 'f') {
+ result = static_cast<T>(result | (s[i] - 'a' + 10));
+ } else {
+ /* Non-digit */
+ return false;
+ }
Review comment:
A lookup table approach may have better performance.
We can leave it as a followup task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
