edponce commented on a change in pull request #11161:
URL: https://github.com/apache/arrow/pull/11161#discussion_r709709414
##########
File path: cpp/src/arrow/compute/kernels/scalar_cast_test.cc
##########
@@ -1485,51 +1485,57 @@ TEST(Cast, StringToBoolean) {
TEST(Cast, StringToInt) {
for (auto string_type : {utf8(), large_utf8()}) {
for (auto signed_type : {int8(), int16(), int32(), int64()}) {
- CheckCast(ArrayFromJSON(string_type, R"(["0", null, "127", "-1", "0"])"),
- ArrayFromJSON(signed_type, "[0, null, 127, -1, 0]"));
+ CheckCast(
+ ArrayFromJSON(string_type, R"(["0", null, "127", "-1", "0", "0x0",
"0x7F"])"),
+ ArrayFromJSON(signed_type, "[0, null, 127, -1, 0, 0, 127]"));
Review comment:
Ohh, sorry...I meant as failing test cases. It is just a way to ensure
more code coverage in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
