thisisnic commented on a change in pull request #11105:
URL: https://github.com/apache/arrow/pull/11105#discussion_r710505110
##########
File path: r/src/compute.cpp
##########
@@ -332,6 +332,13 @@ std::shared_ptr<arrow::compute::FunctionOptions>
make_compute_options(
cpp11::as_cpp<arrow::TimeUnit::type>(options["unit"]));
}
+ if (func_name == "strftime") {
+ using Options = arrow::compute::StrftimeOptions;
+ return std::make_shared<Options>(
+ Options(cpp11::as_cpp<std::string>(options["format"]),
+ cpp11::as_cpp<std::string>(options["locale"])));
+ }
Review comment:
This bit LGTM now!
##########
File path: r/tests/testthat/test-dplyr-string-functions.R
##########
@@ -719,6 +719,40 @@ test_that("errors in strptime", {
)
})
+test_that("strftime", {
+ skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168
+
+ # TODO: consider reevaluating this workaround after ARROW-12980
+ withr::local_timezone("UTC")
+ times <- tibble(x = c(lubridate::ymd_hms("2018-10-07 19:04:05"), NA))
+
+ formats = c("%a", "%A", "%w", "%d", "%b", "%B", "%m", "%y", "%Y", "%H",
+ "%I", "%p", "%M", "%z", "%Z", "%j", "%U", "%W", "%c", "%x",
+ "%X", "%%", "%G", "%V", "%u")
+
+ for (format in formats) {
+ expect_dplyr_equal(
+ input %>%
+ mutate(x = strftime(x, format = format)) %>%
+ collect(),
+ times
+ )
+
+ expect_dplyr_equal(
+ input %>%
+ mutate(x = strftime(x, format = format, usetz = TRUE)) %>%
+ collect(),
+ times
+ )
+
+ x <- Expression$field_ref("x")
+ expect_error(
+ nse_funcs$strftime(x, format = format, tz="Mars/Mariner_Valley"),
+ "tz argument not supported by Arrow"
+ )
+ }
+})
Review comment:
This is looking a lot more along the right lines, but I reckon that this
could be refactored further to be more efficient, and easier to diagnose what's
happening if any of the tests fail.
Please would you refactor so that you remove the `for` loop, and have
`format` as a column in the tibble (you won't need to change the `mutate`
statement), so we just run each of those `expect_*` functions once?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
