thisisnic commented on a change in pull request #11105:
URL: https://github.com/apache/arrow/pull/11105#discussion_r710842031
##########
File path: r/tests/testthat/test-dplyr-string-functions.R
##########
@@ -719,6 +719,40 @@ test_that("errors in strptime", {
)
})
+test_that("strftime", {
+ skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168
+
+ # TODO: consider reevaluating this workaround after ARROW-12980
+ withr::local_timezone("UTC")
+ times <- tibble(x = c(lubridate::ymd_hms("2018-10-07 19:04:05"), NA))
+
+ formats = c("%a", "%A", "%w", "%d", "%b", "%B", "%m", "%y", "%Y", "%H",
+ "%I", "%p", "%M", "%z", "%Z", "%j", "%U", "%W", "%c", "%x",
+ "%X", "%%", "%G", "%V", "%u")
+
+ for (format in formats) {
+ expect_dplyr_equal(
+ input %>%
+ mutate(x = strftime(x, format = format)) %>%
+ collect(),
+ times
+ )
+
+ expect_dplyr_equal(
+ input %>%
+ mutate(x = strftime(x, format = format, usetz = TRUE)) %>%
+ collect(),
+ times
+ )
+
+ x <- Expression$field_ref("x")
+ expect_error(
+ nse_funcs$strftime(x, format = format, tz="Mars/Mariner_Valley"),
+ "tz argument not supported by Arrow"
+ )
+ }
+})
Review comment:
Apologies, my mistake; I'd presumed that we can use a column of a table
as something to pass into the `options` param, but it appears we can't.
Perhaps the solution here is writing multiple separate tests, though I don't
see why you couldn't combine multiple format markers in one test to have a
smaller subset of tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
