Dandandan commented on a change in pull request #1023:
URL: https://github.com/apache/arrow-datafusion/pull/1023#discussion_r712252203
##########
File path: datafusion/src/physical_plan/hash_utils.rs
##########
@@ -80,36 +80,68 @@ fn check_join_set_is_valid(
)));
};
- let remaining = right
- .difference(on_right)
- .cloned()
- .collect::<HashSet<Column>>();
-
- let collisions = left.intersection(&remaining).collect::<HashSet<_>>();
-
- if !collisions.is_empty() {
- return Err(DataFusionError::Plan(format!(
- "The left schema and the right schema have the following
columns with the same name without being on the ON statement: {:?}. Consider
aliasing them.",
- collisions,
- )));
- };
-
Ok(())
}
+/// Information about the index and placement (left or right) of the columns
+#[derive(Debug, Clone)]
+pub struct ColumnIndex {
Review comment:
Not directly related to this PR, but we have `hash_utils` now as module
(also used by hash aggregate) which also contains join-related code.
Maybe it would be better to move this to another module, e.g. join_utils?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
