houqp commented on a change in pull request #1023:
URL: https://github.com/apache/arrow-datafusion/pull/1023#discussion_r712339712
##########
File path: datafusion/src/physical_plan/hash_utils.rs
##########
@@ -26,92 +26,11 @@ use arrow::array::{
TimestampNanosecondArray, UInt16Array, UInt32Array, UInt64Array,
UInt8Array,
};
use arrow::datatypes::{
- ArrowDictionaryKeyType, ArrowNativeType, DataType, Field, Int16Type,
Int32Type,
- Int64Type, Int8Type, Schema, TimeUnit, UInt16Type, UInt32Type, UInt64Type,
UInt8Type,
+ ArrowDictionaryKeyType, ArrowNativeType, DataType, Int16Type, Int32Type,
Int64Type,
+ Int8Type, TimeUnit, UInt16Type, UInt32Type, UInt64Type, UInt8Type,
};
-use std::collections::HashSet;
use std::sync::Arc;
-use crate::logical_plan::JoinType;
Review comment:
moved join specific code into join_utils.rs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]