Dandandan commented on a change in pull request #1029:
URL: https://github.com/apache/arrow-datafusion/pull/1029#discussion_r712351094
##########
File path: datafusion/src/dataframe.rs
##########
@@ -145,7 +145,11 @@ pub trait DataFrame: Send + Sync {
/// # Ok(())
/// # }
/// ```
- fn union(&self, dataframe: Arc<dyn DataFrame>) -> Result<Arc<dyn
DataFrame>>;
+ fn union(
Review comment:
I think a new method e.g. `union_distinct` would make better sense -
having booleans in APIs hurts readability.
alternatively - what about `df.union(df2)?.distinct()?` and not exposing a
new method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
