Dandandan commented on a change in pull request #1029:
URL: https://github.com/apache/arrow-datafusion/pull/1029#discussion_r712360491
##########
File path: datafusion/src/physical_plan/union.rs
##########
@@ -37,23 +37,31 @@ use crate::{
};
use async_trait::async_trait;
-/// UNION ALL execution plan
+/// UNION execution plan
#[derive(Debug)]
pub struct UnionExec {
/// Input execution plan
inputs: Vec<Arc<dyn ExecutionPlan>>,
/// Execution metrics
metrics: ExecutionPlanMetricsSet,
+ /// Union ALL or Union
+ is_all: bool,
Review comment:
Union all and union distinct are quite different, so if we need to add /
change implementations, I think it makes sense to add a new node instead, like
`UnionDistinctExec`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
