lidavidm commented on a change in pull request #11207:
URL: https://github.com/apache/arrow/pull/11207#discussion_r714326580
##########
File path: cpp/src/arrow/dataset/test_util.h
##########
@@ -589,6 +589,23 @@ class FileFormatScanMixin : public
FileFormatFixtureMixin<FormatHelper>,
}
ASSERT_EQ(row_count, GetParam().expected_rows());
}
+ // Ensure batch_size is respected
+ void TestScanBatchSize() {
+ auto reader = GetRecordBatchReader(schema({field("f64", float64())}));
+ auto source = this->GetFileSource(reader.get());
+
+ this->SetSchema(reader->schema()->fields());
+ auto fragment = this->MakeFragment(*source);
+
+ int64_t row_count = 0;
+ opts_->batch_size = 16;
Review comment:
Good point, I bumped it to 17 which is also prime!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
